Skip to content

Android: Fix return type of ISO#17

Merged
lodev09 merged 2 commits into
lodev09:mainfrom
IsaacInsoll:main
Nov 24, 2025
Merged

Android: Fix return type of ISO#17
lodev09 merged 2 commits into
lodev09:mainfrom
IsaacInsoll:main

Conversation

@IsaacInsoll

Copy link
Copy Markdown
Contributor

EG: for an ISO250 shot i was getting something like [100,40], after this fix I just get "250" as expected.

This is good because:

  • Consistent with how the API works on iOS
  • Actual 'useful' number rather than random values that can't easily be interpretted

Returning an array is inconsistent with IOS and also gives some numbers that can't even be easily converted to the 'real' ISO you just get back automatically when this field is a string.
@lodev09

lodev09 commented Nov 24, 2025

Copy link
Copy Markdown
Owner

Please update the type in types.ts as well! thank you!

@IsaacInsoll

Copy link
Copy Markdown
Contributor Author

Awesome, done :)

@lodev09 lodev09 merged commit db06c70 into lodev09:main Nov 24, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants